Skip to content

Fix variadic arginfos for Reflection functions#3798

Closed
carusogabriel wants to merge 1 commit into
php:masterfrom
carusogabriel:fix/variadic-arginfos
Closed

Fix variadic arginfos for Reflection functions#3798
carusogabriel wants to merge 1 commit into
php:masterfrom
carusogabriel:fix/variadic-arginfos

Conversation

@carusogabriel

Copy link
Copy Markdown
Contributor

Reopening #2492 and #3441 against master branch (PHP 8.0 now).

This fixes #71416.

@carusogabriel carusogabriel added this to the PHP 8.0 milestone Feb 7, 2019
@nikic

nikic commented Feb 7, 2019

Copy link
Copy Markdown
Member

@Majkl578 I think your comment from #3797 might have been intended for here. However, even here there is a way to be compatible with both old and new signature: https://3v4l.org/5OiNF

Given that, I think we should go ahead here.

@carusogabriel

Copy link
Copy Markdown
Contributor Author

Merged with #3797.

@carusogabriel carusogabriel deleted the fix/variadic-arginfos branch February 8, 2019 01:25
@carusogabriel carusogabriel removed this from the PHP 8.0 milestone Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants